test: change var to const in parallel/test-stream-transform-final* - #30448
Closed
khoumani wants to merge 1 commit into
Closed
test: change var to const in parallel/test-stream-transform-final*#30448khoumani wants to merge 1 commit into
khoumani wants to merge 1 commit into
Conversation
nodejs-github-bot
added
the
test
cjihrig
approved these changes
Nov 12, 2019
gireeshpunathil
added
the
code-and-learn
devnexen
approved these changes
Nov 12, 2019
gengjiawen
approved these changes
Nov 13, 2019
trivikr
approved these changes
Nov 13, 2019
BridgeAR
approved these changes
Nov 13, 2019
BridgeAR
added
the
author ready
Member
jasnell
approved these changes
Nov 14, 2019
danbev
pushed a commit
that referenced
this pull request
Nov 15, 2019
PR-URL: #30448 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Contributor
|
Landed in 86f0b75 🎉 |
Member
|
The commit author isn't the same as PR author |
MylesBorins
pushed a commit
that referenced
this pull request
Nov 17, 2019
PR-URL: #30448 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
Dec 1, 2019
PR-URL: #30448 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Dec 17, 2019
PR-URL: #30448 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change var to const in comments in parallel/test-stream-transform-final.js and parallel/test-stream-transform-final-sync.js
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes