tools: update remark-preset-lint-node to 1.12.0 - #31359
Merged
Merged
Conversation
Trott
added
fast-track
BridgeAR
approved these changes
Jan 14, 2020
BridgeAR
added
the
author ready
Member
Author
|
@nodejs/linting |
trivikr
approved these changes
Jan 15, 2020
Member
Author
|
Landed in 6623481...7ab33f2 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jan 15, 2020
This adds linting for "hostname" in prose. PR-URL: nodejs#31359 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 16, 2020
This adds linting for "hostname" in prose. PR-URL: #31359 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 16, 2020
Remove rollup dependencies in markdown linting tool's package.json. We use @zeit/ncc. PR-URL: #31359 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 14, 2020
This adds linting for "hostname" in prose. PR-URL: #31359 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Mar 14, 2020
Remove rollup dependencies in markdown linting tool's package.json. We use @zeit/ncc. PR-URL: #31359 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Mar 17, 2020
This adds linting for "hostname" in prose. PR-URL: #31359 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Mar 17, 2020
Remove rollup dependencies in markdown linting tool's package.json. We use @zeit/ncc. PR-URL: #31359 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds linting for "hostname" in prose.
This also re-adds @zeit/ncc which is required to build. It was removed in 80fb153 but that was in error.
I'd like to fast-track this to prevent other instances of "hostname" from slipping in while this remains open. 👍 here to approve, or comment to block.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes