cli: --perf-prof only works on Linux

[codebytere]

--perf-prof-related flags have been removed in V8 on non-linux devices, and so we should note that in testing here as well as in docs.

See:

• https://chromium-review.googlesource.com/c/v8/v8/+/1993969
• https://chromium-review.googlesource.com/c/v8/v8/+/1993978

This broke in Electron, which is how i discovered it.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[gireeshpunathil]

they (v8) did have a (documented?) promise that they would consider Node's compatibility as a major factor while implementing features?

[codebytere]

@gireeshpunathil i'm pretty sure they don't consider this an issue with compat considering Node.js was piping straight through to V8's own bespoke option; we also already gate some --perf-prof options to linux, as you can see in the testfile, owing to similar changes upstream.

[mmarchini]

--perf-prof doesn't make much sense on outside of Linux, as it generates a jitdump file.

--perf-basic-prof on the other hand could be used on other platforms, since it is just a text file (I have used it on OS X in the past). Well, that's not really a Node.js issue though. I'll get in touch with V8 about that.

[codebytere]

thanks @mmarchini 🙇‍♀

[gireeshpunathil]

ok, thanks @mmarchini, that will really help!

for the context, my use case is here: https://github.com/nodejs/diagnostics/tree/master/documentation/profiling - attempt to document diagnostic best practices around profiling. These are aimed at user-journey driven, endorsed by node project, and planned to be supported for long term.

as that is a conversation with v8, and this PR is just documenting the code behavior that was uncovered in the field, it looks good to me!

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/29297/

[codebytere]

Landed in 72b6cea