Skip to content

test: mark test-child-process-fork-args as flaky on Windows - #32950

Closed
puzpuzpuz wants to merge 1 commit into
nodejs:masterfrom
puzpuzpuz:mark-test-child-process-fork-args-as-flaky
Closed

test: mark test-child-process-fork-args as flaky on Windows#32950
puzpuzpuz wants to merge 1 commit into
nodejs:masterfrom
puzpuzpuz:mark-test-child-process-fork-args-as-flaky

Conversation

@puzpuzpuz

@puzpuzpuz puzpuzpuz commented Apr 20, 2020

Copy link
Copy Markdown
Member
Checklist

Refs: #32863

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@puzpuzpuz puzpuzpuz added the test Issues and PRs related to Node.js core tests and test infrastructure. label Apr 20, 2020
@puzpuzpuz puzpuzpuz mentioned this pull request Apr 20, 2020
Closed
sam-github
sam-github approved these changes Apr 20, 2020
View reviewed changes

@sam-github sam-github left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
@sam-github

sam-github commented Apr 20, 2020

Copy link
Copy Markdown
Contributor

fast-track?
@nodejs-github-bot

nodejs-github-bot commented Apr 21, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30877/
@nodejs-github-bot

nodejs-github-bot commented Apr 21, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30879/
@puzpuzpuz puzpuzpuz added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Apr 21, 2020
puzpuzpuz added a commit that referenced this pull request Apr 21, 2020
@puzpuzpuz
test: mark test-child-process-fork-args as flaky on Windows
7893c70 
PR-URL: #32950
Refs: #32863
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@puzpuzpuz

puzpuzpuz commented Apr 21, 2020

Copy link
Copy Markdown
Member Author

Landed in 7893c70
@puzpuzpuz puzpuzpuz closed this Apr 21, 2020
@puzpuzpuz
puzpuzpuz deleted the mark-test-child-process-fork-args-as-flaky branch April 21, 2020 09:56
BethGriggs pushed a commit that referenced this pull request Apr 27, 2020
@puzpuzpuz @BethGriggs
test: mark test-child-process-fork-args as flaky on Windows
c9ae385 
PR-URL: #32950
Refs: #32863
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Apr 27, 2020
Merged
BridgeAR pushed a commit that referenced this pull request Apr 28, 2020
@puzpuzpuz @BridgeAR
test: mark test-child-process-fork-args as flaky on Windows
944e010 
PR-URL: #32950
Refs: #32863
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Apr 28, 2020
Merged
targos pushed a commit that referenced this pull request Apr 30, 2020
@puzpuzpuz @targos
test: mark test-child-process-fork-args as flaky on Windows
f7125d2 
PR-URL: #32950
Refs: #32863
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@targos targos mentioned this pull request May 2, 2020
Merged
targos pushed a commit that referenced this pull request May 13, 2020
@puzpuzpuz @targos
test: mark test-child-process-fork-args as flaky on Windows
0bae243 
PR-URL: #32950
Refs: #32863
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track PRs proposed for a shorter-than-standard waiting period before landing. test Issues and PRs related to Node.js core tests and test infrastructure.

6 participants

@puzpuzpuz @sam-github @nodejs-github-bot @lpinca @richardlau @juanarbol