http2: avoid Object.create(null) for Http2ServerRequest.headers - #33183
Closed
rexagod wants to merge 4 commits into
Closed
http2: avoid Object.create(null) for Http2ServerRequest.headers#33183rexagod wants to merge 4 commits into
Object.create(null) for Http2ServerRequest.headers#33183rexagod wants to merge 4 commits into
Conversation
Member
|
The use of |
jasnell
approved these changes
May 4, 2020
addaleax
approved these changes
May 5, 2020
cjihrig
approved these changes
May 5, 2020
Member
|
Landed in ee87567 :) |
32 tasks
codebytere
pushed a commit
to codebytere/node
that referenced
this pull request
Jun 9, 2020
Refs: nodejs#29829 PR-URL: nodejs#33183 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
Merged
QwireyInc
pushed a commit
to QwireyInc/node
that referenced
this pull request
Apr 19, 2025
Refs: nodejs/node#29829 PR-URL: nodejs/node#33183 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently http2.Http2ServerRequest.headers returns headers which is initialized by Object.create(null) which is a different behaviour than what is seen in http.
Refs: #29829
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes