Skip to content

doc: specify default encoding in writable.write - #33765

Closed
rexagod wants to merge 2 commits into
nodejs:masterfrom
rexagod:writable-write-enc-docs
Closed

doc: specify default encoding in writable.write#33765
rexagod wants to merge 2 commits into
nodejs:masterfrom
rexagod:writable-write-enc-docs

Conversation

@rexagod

@rexagod rexagod commented Jun 6, 2020

Copy link
Copy Markdown
Member

Refs: #33715

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. stream Issues and PRs related to Node.js streams. labels Jun 6, 2020
Trott
Trott reviewed Jun 6, 2020
View reviewed changes
Comment thread doc/api/stream.md Outdated
@rexagod @Trott
Update doc/api/stream.md
c6b7f8d 
Co-authored-by: Rich Trott <rtrott@gmail.com>
@Trott Trott added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Jun 6, 2020
jasnell pushed a commit that referenced this pull request Jun 19, 2020
@rexagod @jasnell
doc: specify default encoding in writable.write
9dcde52 
Refs: #33715

PR-URL: #33765
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

jasnell commented Jun 19, 2020

Copy link
Copy Markdown
Member

Landed in 9dcde52
@jasnell jasnell closed this Jun 19, 2020
codebytere pushed a commit that referenced this pull request Jun 22, 2020
@rexagod @codebytere
doc: specify default encoding in writable.write
76fe2a9 
Refs: #33715

PR-URL: #33765
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Jun 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
@rexagod @codebytere
doc: specify default encoding in writable.write
8bc1f66 
Refs: #33715

PR-URL: #33765
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere pushed a commit that referenced this pull request Jul 10, 2020
@rexagod @codebytere
doc: specify default encoding in writable.write
3789c28 
Refs: #33715

PR-URL: #33765
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Jul 13, 2020
Merged
codebytere pushed a commit that referenced this pull request Jul 14, 2020
@rexagod @codebytere
doc: specify default encoding in writable.write
e5a1ca2 
Refs: #33715

PR-URL: #33765
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. stream Issues and PRs related to Node.js streams.

7 participants

@rexagod @jasnell @Trott @lpinca @trivikr @MrSlimCoder @nodejs-github-bot