internal: rename error-serdes for consistency - #33793
Merged
Merged
Conversation
nodejs-github-bot
added
build
cjihrig
approved these changes
Jun 8, 2020
lpinca
approved these changes
Jun 8, 2020
addaleax
approved these changes
Jun 8, 2020
benjamingr
approved these changes
Jun 8, 2020
Collaborator
This was referenced Jun 9, 2020
All other JavaScript files in lib use snake case, so make this one consistent. PR-URL: nodejs#33793 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
evanlucas
force-pushed
the
node-consistency
branch
from
June 23, 2020 16:36
70bffe9 to
f6dbba8
Compare
codebytere
pushed a commit
that referenced
this pull request
Jun 27, 2020
All other JavaScript files in lib use snake case, so make this one consistent. PR-URL: #33793 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
All other JavaScript files in lib use snake case, so make this one consistent. PR-URL: #33793 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Sep 27, 2020
All other JavaScript files in lib use snake case, so make this one consistent. PR-URL: #33793 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Sep 28, 2020
All other JavaScript files in lib use snake case, so make this one consistent. PR-URL: #33793 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All other JavaScript files in lib use snake case, so make this
one consistent.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes