Skip to content

[v12.x backport] doc: standardize on sentence case for headers - #33964

Closed
Trott wants to merge 2 commits into
nodejs:v12.x-stagingfrom
Trott:case-12
Closed

[v12.x backport] doc: standardize on sentence case for headers#33964
Trott wants to merge 2 commits into
nodejs:v12.x-stagingfrom
Trott:case-12

Conversation

@Trott

@Trott Trott commented Jun 19, 2020

Copy link
Copy Markdown
Member

Backport for #33889

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. v12.x labels Jun 19, 2020
@Trott
Trott marked this pull request as draft June 19, 2020 14:14
Trott added 2 commits June 19, 2020 08:24
Previously, our documentation headers were a mixture of title case,
sentence case, and things that were neither. For technical
documentation, the _de facto_ standard seems to be sentence case. (See
refs below.) So let's standardize on that. This commit follows a
commit implementing this standard. This commit adds it to the style
guide.

Refs: https://developers.google.com/style/capitalization#capitalization-in-titles-and-headings
Refs: https://docs.microsoft.com/en-us/style-guide/capitalization

PR-URL: nodejs#33889
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott
Trott marked this pull request as ready for review June 19, 2020 15:26
@Trott

Trott commented Jun 19, 2020

Copy link
Copy Markdown
Member Author

Ready for review, I think.

@Trott

Trott commented Jul 6, 2020

Copy link
Copy Markdown
Member Author

@nodejs/backporters

@codebytere codebytere left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codebytere

Copy link
Copy Markdown
Member

Landed in 83c9364...70d025f

@codebytere codebytere closed this Jul 8, 2020
codebytere pushed a commit that referenced this pull request Jul 8, 2020
PR-URL: #33889
Backport-PR-URL: #33964
Refs: https://developers.google.com/style/capitalization#capitalization-in-titles-and-headings
Refs: https://docs.microsoft.com/en-us/style-guide/capitalization
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere pushed a commit that referenced this pull request Jul 8, 2020
Previously, our documentation headers were a mixture of title case,
sentence case, and things that were neither. For technical
documentation, the _de facto_ standard seems to be sentence case. (See
refs below.) So let's standardize on that. This commit follows a
commit implementing this standard. This commit adds it to the style
guide.

Refs: https://developers.google.com/style/capitalization#capitalization-in-titles-and-headings
Refs: https://docs.microsoft.com/en-us/style-guide/capitalization

PR-URL: #33889
Backport-PR-URL: #33964
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott
Trott deleted the case-12 branch April 14, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to Node.js documentation.

5 participants