Skip to content

build: omit -gline-tables-only for --enable-asan - #3680

Merged
bnoordhuis merged 1 commit into
nodejs:masterfrom
bnoordhuis:fix3656
Nov 5, 2015
Merged

build: omit -gline-tables-only for --enable-asan#3680
bnoordhuis merged 1 commit into
nodejs:masterfrom
bnoordhuis:fix3656

Conversation

@bnoordhuis

@bnoordhuis bnoordhuis commented Nov 5, 2015

Copy link
Copy Markdown
Member

-gline-tables-only is a clang-only flag. Drop it, it's not needed for
address sanitizer-enabled builds and it makes it impossible to build
with gcc.

Fixes: #3656

No CI, we don't build with ASAN yet.
@bnoordhuis

bnoordhuis commented Nov 5, 2015

Copy link
Copy Markdown
Member Author

R=@indutny or @skomski?
@bnoordhuis bnoordhuis mentioned this pull request Nov 5, 2015
Closed
@indutny

indutny commented Nov 5, 2015

Copy link
Copy Markdown
Member

LGTM
@bnoordhuis
build: omit -gline-tables-only for --enable-asan
d461a07 
`-gline-tables-only` is a clang-only flag.  Drop it, it's not needed for
address sanitizer-enabled builds and it makes it impossible to build
with gcc.

Fixes: nodejs#3656
PR-URL: nodejs#3680
Reviewed-By: Fedor Indutny <fedor@indutny.com>
@bnoordhuis bnoordhuis closed this Nov 5, 2015
@bnoordhuis
bnoordhuis deleted the fix3656 branch November 5, 2015 17:39
@bnoordhuis
bnoordhuis merged commit d461a07 into nodejs:master Nov 5, 2015
@Fishrock123 Fishrock123 mentioned this pull request Nov 6, 2015
Closed
bnoordhuis added a commit that referenced this pull request Nov 7, 2015
@bnoordhuis @rvagg
build: omit -gline-tables-only for --enable-asan
8f5a255 
`-gline-tables-only` is a clang-only flag.  Drop it, it's not needed for
address sanitizer-enabled builds and it makes it impossible to build
with gcc.

Fixes: #3656
PR-URL: #3680
Reviewed-By: Fedor Indutny <fedor@indutny.com>
@Fishrock123 Fishrock123 mentioned this pull request Nov 11, 2015
Merged
@rvagg rvagg mentioned this pull request Dec 17, 2015
Closed
bnoordhuis added a commit that referenced this pull request Dec 29, 2015
@bnoordhuis Myles Borins
build: omit -gline-tables-only for --enable-asan
6d9d37f 
`-gline-tables-only` is a clang-only flag.  Drop it, it's not needed for
address sanitizer-enabled builds and it makes it impossible to build
with gcc.

Fixes: #3656
PR-URL: #3680
Reviewed-By: Fedor Indutny <fedor@indutny.com>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
@bnoordhuis Myles Borins
build: omit -gline-tables-only for --enable-asan
e6c2533 
`-gline-tables-only` is a clang-only flag.  Drop it, it's not needed for
address sanitizer-enabled builds and it makes it impossible to build
with gcc.

Fixes: #3656
PR-URL: #3680
Reviewed-By: Fedor Indutny <fedor@indutny.com>
@MylesBorins MylesBorins mentioned this pull request Jan 19, 2016
Merged
@stevinus73

This comment has been minimized.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants

@bnoordhuis @indutny @stevinus73 @jasnell @MylesBorins