Skip to content

doc: add romankl to collaborators - #3725

Closed
r-52 wants to merge 1 commit into
nodejs:masterfrom
r-52:add-to-collab
Closed

doc: add romankl to collaborators#3725
r-52 wants to merge 1 commit into
nodejs:masterfrom
r-52:add-to-collab

Conversation

@r-52

@r-52 r-52 commented Nov 9, 2015

Copy link
Copy Markdown
Contributor

No description provided.

@MylesBorins

Copy link
Copy Markdown
Contributor

LGTM

3 similar comments
@evanlucas

Copy link
Copy Markdown
Contributor

LGTM

@Fishrock123

Copy link
Copy Markdown
Contributor

LGTM

@Trott

Trott commented Nov 9, 2015

Copy link
Copy Markdown
Member

LGTM

@Fishrock123

Copy link
Copy Markdown
Contributor

Aside:

@romankl you should probably add yourself to the [mailmap] so that your old git info of Roman Klauke <romankl@users.noreply.github.com> maps to your new email.

@Fishrock123 Fishrock123 added the doc Issues and PRs related to Node.js documentation. label Nov 9, 2015
@saghul

saghul commented Nov 9, 2015

Copy link
Copy Markdown
Member

LGTM

@jbergstroem

Copy link
Copy Markdown
Member

🎉 !

@thefourtheye

Copy link
Copy Markdown
Contributor

This one-liner has a conflict 😮

@r-52

r-52 commented Nov 10, 2015

Copy link
Copy Markdown
Contributor Author

@Fishrock123 should I include the update in this pr or wait till the next "update AUTHORs" pr ?

@jbergstroem

Copy link
Copy Markdown
Member

@romankl rebase this branch onto latest master and force push the commit to this branch (to make sure).

@Fishrock123

Copy link
Copy Markdown
Contributor

@romankl no that can be done in a separate commit. :)

r-52 added a commit that referenced this pull request Nov 10, 2015
PR-URL: #3725
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
Reviewed-By: Myles Borins <mborins@us.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@r-52

r-52 commented Nov 10, 2015

Copy link
Copy Markdown
Contributor Author

Thank you!! Landed in 5235143

@r-52 r-52 closed this Nov 10, 2015
@r-52
r-52 deleted the add-to-collab branch November 10, 2015 18:52
r-52 added a commit that referenced this pull request Nov 11, 2015
PR-URL: #3725
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
Reviewed-By: Myles Borins <mborins@us.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@Fishrock123 Fishrock123 mentioned this pull request Nov 11, 2015
r-52 added a commit that referenced this pull request Nov 17, 2015
PR-URL: #3725
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
Reviewed-By: Myles Borins <mborins@us.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@MylesBorins

Copy link
Copy Markdown
Contributor

landed in v4.x-staging in a49dd89

r-52 added a commit that referenced this pull request Dec 4, 2015
PR-URL: #3725
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
Reviewed-By: Myles Borins <mborins@us.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@jasnell jasnell mentioned this pull request Dec 17, 2015
r-52 added a commit that referenced this pull request Dec 17, 2015
PR-URL: #3725
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
Reviewed-By: Myles Borins <mborins@us.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
r-52 added a commit that referenced this pull request Dec 23, 2015
PR-URL: #3725
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
Reviewed-By: Myles Borins <mborins@us.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to Node.js documentation.

9 participants