Skip to content

doc: change lang info string in fs JS snippets - #37605

Merged
Trott merged 1 commit into
nodejs:masterfrom
aduh95:fs-lang-fenced
Mar 6, 2021
Merged

doc: change lang info string in fs JS snippets #37605
Trott merged 1 commit into
nodejs:masterfrom
aduh95:fs-lang-fenced

Conversation

@aduh95

@aduh95 aduh95 commented Mar 4, 2021

Copy link
Copy Markdown
Contributor
@aduh95 aduh95 added doc Issues and PRs related to Node.js documentation. blocked PRs that are blocked by other issues or PRs. labels Mar 4, 2021
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Mar 4, 2021
@aduh95 aduh95 removed the blocked PRs that are blocked by other issues or PRs. label Mar 4, 2021
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. and removed tools Issues and PRs related to the tools directory. labels Mar 4, 2021
@jasnell jasnell added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Mar 5, 2021
@jasnell

jasnell commented Mar 5, 2021

Copy link
Copy Markdown
Member

fast-track?

@aduh95 aduh95 self-assigned this Mar 5, 2021
@aduh95

aduh95 commented Mar 6, 2021

Copy link
Copy Markdown
Contributor Author

Anyone wants to 👍 the fast track request so I can land #37311?

Refs: nodejs/remark-preset-lint-node#176

PR-URL: nodejs#37605
Refs: nodejs#37162
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@Trott

Trott commented Mar 6, 2021

Copy link
Copy Markdown
Member

Landed in 0946164

@Trott
Trott merged commit 0946164 into nodejs:master Mar 6, 2021
@aduh95
aduh95 deleted the fs-lang-fenced branch March 6, 2021 15:03
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
Refs: nodejs/remark-preset-lint-node#176

PR-URL: #37605
Refs: #37162
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
targos pushed a commit to targos/node that referenced this pull request Aug 8, 2021
Refs: nodejs/remark-preset-lint-node#176

PR-URL: nodejs#37605
Refs: nodejs#37162
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
targos pushed a commit to targos/node that referenced this pull request Sep 1, 2021
Refs: nodejs/remark-preset-lint-node#176

PR-URL: nodejs#37605
Refs: nodejs#37162
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
targos pushed a commit that referenced this pull request Sep 1, 2021
Refs: nodejs/remark-preset-lint-node#176

PR-URL: #37605
Refs: #37162
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing.

9 participants