Throw within queueMicrotask callbacks should not crash Node - #38225
Closed
EladKeyshawn wants to merge 1 commit into
Closed
Throw within queueMicrotask callbacks should not crash Node#38225EladKeyshawn wants to merge 1 commit into
EladKeyshawn wants to merge 1 commit into
Conversation
nodejs-github-bot
added
needs-ci
Member
|
@Linkgoron was looking at this IIRC |
Contributor
|
This would fix the issue, but this change was done on purpose. This basically reverts #33859. I think that the real issue is in the c++ code that handles the error, and loses the correct async context. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#38145 Why was this 'catch' block was removed in the first place?