Skip to content

test: move inspector-cli tests to sequential - #39079

Merged
Trott merged 1 commit into
nodejs:masterfrom
Trott:mv-test
Jun 21, 2021
Merged

test: move inspector-cli tests to sequential#39079
Trott merged 1 commit into
nodejs:masterfrom
Trott:mv-test

Conversation

@Trott

@Trott Trott commented Jun 19, 2021

Copy link
Copy Markdown
Member

There's no reason to keep these tests separated from everything else.

@github-actions github-actions Bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Jun 19, 2021
There's no reason to keep these tests separated from everything else.

PR-URL: nodejs#39079
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott

Trott commented Jun 21, 2021

Copy link
Copy Markdown
Member Author

Landed in 15ad006

@Trott
Trott merged commit 15ad006 into nodejs:master Jun 21, 2021
@Trott
Trott deleted the mv-test branch June 21, 2021 02:39
danielleadams pushed a commit that referenced this pull request Jun 21, 2021
There's no reason to keep these tests separated from everything else.

PR-URL: #39079
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request Jun 21, 2021
codebytere added a commit to electron/electron that referenced this pull request Jun 24, 2021
codebytere added a commit to electron/electron that referenced this pull request Jun 24, 2021
richardlau pushed a commit that referenced this pull request Jul 19, 2021
There's no reason to keep these tests separated from everything else.

PR-URL: #39079
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
There's no reason to keep these tests separated from everything else.

PR-URL: #39079
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@richardlau richardlau mentioned this pull request Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

5 participants