Skip to content

tools: update minimatch index path#52523

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
marco-ippolito:fix/minimatch-broken
Apr 15, 2024
Merged

tools: update minimatch index path#52523
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
marco-ippolito:fix/minimatch-broken

Conversation

@marco-ippolito

@marco-ippolito marco-ippolito commented Apr 14, 2024

Copy link
Copy Markdown
Member

Fixes: #52520
@nodejs-github-bot

nodejs-github-bot commented Apr 14, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Apr 14, 2024
targos
targos approved these changes Apr 14, 2024
View reviewed changes

@targos targos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming you tested the script locally.
@targos targos added the fast-track PRs that do not need to wait for 72 hours to land. label Apr 14, 2024
@github-actions

github-actions Bot commented Apr 14, 2024

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @targos. Please 👍 to approve.
@marco-ippolito

marco-ippolito commented Apr 14, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

LGTM assuming you tested the script locally.

yes 😄 I could give it a run with the action
RUN: https://github.com/nodejs/node/actions/runs/8679232857/job/23797550354 ✅
PR created: #52524
@MoLow MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 15, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 15, 2024
@nodejs-github-bot nodejs-github-bot merged commit 0debfa4 into nodejs:main Apr 15, 2024
@nodejs-github-bot

nodejs-github-bot commented Apr 15, 2024

Copy link
Copy Markdown
Collaborator

Landed in 0debfa4
aduh95 pushed a commit that referenced this pull request Apr 29, 2024
@marco-ippolito @aduh95
tools: update minimatch index path
15c5686 
PR-URL: #52523
Fixes: #52520
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@aduh95 aduh95 mentioned this pull request Apr 30, 2024
Merged
marco-ippolito added a commit that referenced this pull request May 2, 2024
@marco-ippolito
tools: update minimatch index path
babb6f9 
PR-URL: #52523
Fixes: #52520
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@marco-ippolito marco-ippolito mentioned this pull request May 2, 2024
Merged
marco-ippolito added a commit that referenced this pull request May 3, 2024
@marco-ippolito
tools: update minimatch index path
c681336 
PR-URL: #52523
Fixes: #52520
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track PRs that do not need to wait for 72 hours to land. tools Issues and PRs related to the tools directory.

7 participants

@marco-ippolito @nodejs-github-bot @benjamingr @lpinca @targos @gireeshpunathil @MoLow