build: make simdjson a public dep in GN build#52755
Merged
Merged
Conversation
benjamingr
approved these changes
Apr 30, 2024
lpinca
approved these changes
Apr 30, 2024
github-actions
Bot
removed
the
request-ci
Collaborator
Collaborator
zcbenz
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 77db391 |
Ch3nYuY
pushed a commit
to Ch3nYuY/node
that referenced
this pull request
May 8, 2024
PR-URL: nodejs#52755 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 8, 2024
PR-URL: #52755 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Jun 17, 2024
PR-URL: #52755 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
soophoo
pushed a commit
to soophoo/node
that referenced
this pull request
Jun 20, 2024
PR-URL: nodejs#52755 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
PR-URL: nodejs#52755 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With a6b80c7,
simdjson.hgot exposed to public headers (viaenv.h->inspector_profiler.h), and thesimdjsonshould be listed as a public dep to make it's header available to libnode's dependents.