test: fix Linux debug skip in SEA test guard - #63751
Merged
nodejs-github-bot merged 2 commits intoAug 21, 2026
Merged
Conversation
process.config.variables.is_debug is only populated by the GN build flow (tools/generate_config_gypi.py), so on the gyp builds used by CI the guard never fired and SEA tests ran on Linux debug builds against the original intent. Switch to process.config.target_defaults.default_configuration === 'Debug', matching the pattern used in test/common/index.js. Fixes: nodejs#63749 Refs: nodejs#61483 Signed-off-by: Hyunwoo Gu <realization0327@gmail.com>
nodejs-github-bot
added
needs-ci
joyeecheung
reviewed
Jun 9, 2026
Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
joyeecheung
approved these changes
Jul 20, 2026
github-actions
Bot
removed
the
request-ci
Collaborator
github-actions
Bot
removed
the
request-ci
Collaborator
richardlau
approved these changes
Aug 19, 2026
Collaborator
Collaborator
jasnell
approved these changes
Aug 20, 2026
Collaborator
richardlau
added
commit-queue
Collaborator
|
Landed in 9ea6182 |
nodejs-github-bot
removed
the
commit-queue
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
process.config.variables.is_debug is only populated by the GN build flow (tools/generate_config_gypi.py), so on the gyp builds used by CI the guard never fired and SEA tests ran on Linux debug builds against the original intent. Switch to process.config.target_defaults.default_configuration === 'Debug', matching the pattern used in test/common/index.js. Fixes: #63749 Refs: #61483 Signed-off-by: Hyunwoo Gu <realization0327@gmail.com> PR-URL: #63751 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
process.config.variables.is_debug is only populated by the GN build flow (tools/generate_config_gypi.py), so on the gyp builds used by CI the guard never fired and SEA tests ran on Linux debug builds against the original intent. Switch to process.config.target_defaults.default_configuration === 'Debug', matching the pattern used in test/common/index.js. Fixes: #63749 Refs: #61483 Signed-off-by: Hyunwoo Gu <realization0327@gmail.com> PR-URL: #63751 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Aug 27, 2026
process.config.variables.is_debug is only populated by the GN build flow (tools/generate_config_gypi.py), so on the gyp builds used by CI the guard never fired and SEA tests ran on Linux debug builds against the original intent. Switch to process.config.target_defaults.default_configuration === 'Debug', matching the pattern used in test/common/index.js. Fixes: #63749 Refs: #61483 Signed-off-by: Hyunwoo Gu <realization0327@gmail.com> PR-URL: #63751 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
process.config.variables.is_debugis only populated by the GN build flow (tools/generate_config_gypi.py). As a result, on the gyp builds used by CI the guard never fired, causing SEA tests to run on Linux debug builds contrary to the original intent.Verified locally that
'is_debug' in process.config.variablesevaluates tofalseon a gyp release build.Switch to checking
process.config.target_defaults.default_configuration === 'Debug'instead, matching the approach already used intest/common/index.js.Fixes: #63749
Refs: #61483