Skip to content

tools: reference 'git node land' in PR-URL: error message in merge.sh - #64495

Merged
sxa merged 1 commit into
nodejs:mainfrom
sxa:merge_reviewer_check
Jul 16, 2026
Merged

tools: reference 'git node land' in PR-URL: error message in merge.sh#64495
sxa merged 1 commit into
nodejs:mainfrom
sxa:merge_reviewer_check

Conversation

@sxa

@sxa sxa commented Jul 14, 2026

Copy link
Copy Markdown
Member

Supercedes #64363 based on:

I would still land the wording change reminding the user if they ran git node land

from @aduh95

I could have forced it into that PR to adjust the original commit messages but decided it would be cleaner In a separate PR given that the title/subject line needed to be changed.

@sxa
sxa requested a review from aduh95 July 14, 2026 09:21
@sxa sxa self-assigned this Jul 14, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jul 14, 2026
@aduh95

aduh95 commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

The commit message doesn't match the change

Signed-off-by: Stewart X Addison <sxa@ibm.com>
@sxa
sxa force-pushed the merge_reviewer_check branch from e1d8675 to 765616e Compare July 15, 2026 11:40
@sxa sxa changed the title tools: add check for Reviewed-by: to merge.sh Jul 15, 2026
@sxa
sxa merged commit 61b8e12 into nodejs:main Jul 16, 2026
12 checks passed
@sxa

sxa commented Jul 16, 2026

Copy link
Copy Markdown
Member Author

Landed in 61b8e12

aduh95 pushed a commit that referenced this pull request Jul 21, 2026
Signed-off-by: Stewart X Addison <sxa@ibm.com>
PR-URL: #64495
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 21, 2026
Signed-off-by: Stewart X Addison <sxa@ibm.com>
PR-URL: #64495
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jul 29, 2026
Signed-off-by: Stewart X Addison <sxa@ibm.com>
PR-URL: #64495
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request Aug 6, 2026
Signed-off-by: Stewart X Addison <sxa@ibm.com>
PR-URL: #64495
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tools Issues and PRs related to the tools directory.

4 participants