fix: prefer fs/promises over promisify#7399
Merged
Merged
Conversation
Contributor
|
This is likely to collide w/ my "remove tables" PR, I'll push it up tomorrow and would like to land that first. |
wraithgar
reviewed
Apr 22, 2024
wraithgar
reviewed
Apr 22, 2024
lukekarrys
force-pushed
the
lk/more-fs-promises
branch
3 times, most recently
from
d8624ed to
67b9431
Compare
lukekarrys
force-pushed
the
lk/more-fs-promises
branch
from
67b9431 to
c796af3
Compare
wraithgar
reviewed
Apr 23, 2024
wraithgar
reviewed
Apr 23, 2024
wraithgar
reviewed
Apr 23, 2024
Contributor
|
Arborist had more than needed individual comments but it seems we aren't consistently using Also should it be |
Contributor
Author
|
The sync methods are not available from |
wraithgar
approved these changes
Apr 23, 2024
Contributor
|
After reviewing again I was wrong, I remembered the |
wraithgar
approved these changes
Apr 23, 2024
lukekarrys
force-pushed
the
lk/more-fs-promises
branch
from
ae83cb3 to
c796af3
Compare
Merged
This was referenced Apr 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.