Skip to content
This repository was archived by the owner on Aug 11, 2022. It is now read-only.

pack: add shasum and integrity info to preview #20257

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
pack: add shasum and integrity info to preview
  • Loading branch information
zkat committed Apr 4, 2018
commit 2332c5f9858bf2599761dbc0764e22a2d89d8b75
41 changes: 28 additions & 13 deletions lib/pack.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ const pinflight = require('promise-inflight')
const readJson = BB.promisify(require('read-package-json'))
const tar = require('tar')
const packlist = require('npm-packlist')
const ssri = require('ssri')

pack.usage = 'npm pack [[<@scope>/]<pkg>...]'

Expand Down Expand Up @@ -195,6 +196,10 @@ function logContents (tarball) {
tarball.filename && {name: 'filename:', value: tarball.filename},
{name: 'package size:', value: byteSize(tarball.size)},
{name: 'unpacked size:', value: byteSize(tarball.unpackedSize)},
{name: 'shasum:', value: tarball.shasum},
{
name: 'integrity:',
value: tarball.integrity.toString().substr(0, 20) + '[...]' + tarball.integrity.toString().substr(80)},
tarball.bundled.length && {name: 'bundled deps:', value: tarball.bundled.length},
tarball.bundled.length && {name: 'bundled files:', value: tarball.entryCount - tarball.files.length},
tarball.bundled.length && {name: 'own files:', value: tarball.files.length},
Expand Down Expand Up @@ -238,19 +243,29 @@ function getContents (pkg, target, filename, silent) {
},
strip: 1
})
.then(() => BB.fromNode((cb) => fs.stat(target, cb)))
.then((stat) => ({
id: pkg._id,
name: pkg.name,
version: pkg.version,
from: pkg._from,
size: stat.size,
unpackedSize: totalEntrySize,
filename,
files,
entryCount: totalEntries,
bundled: Array.from(bundled)
}))
.then(() => BB.all([
BB.fromNode((cb) => fs.stat(target, cb)),
ssri.fromStream(fs.createReadStream(target), {
algorithms: ['sha1', 'sha512']
})
]))
.then(([stat, integrity]) => {
const shasum = integrity['sha1'][0].hexDigest()
return {
id: pkg._id,
name: pkg.name,
version: pkg.version,
from: pkg._from,
size: stat.size,
unpackedSize: totalEntrySize,
shasum,
integrity: ssri.parse(integrity['sha512'][0]),
filename,
files,
entryCount: totalEntries,
bundled: Array.from(bundled)
}
})
}

const PASSTHROUGH_OPTS = [
Expand Down
2 changes: 1 addition & 1 deletion lib/publish.js
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ function upload (arg, pkg, isRetry, cached) {
}

if (npm.config.get('dry-run')) {
log.info('publish', '--dry-run mode enabled. Skipping upload.')
log.verbose('publish', '--dry-run mode enabled. Skipping upload.')
return BB.resolve()
}

Expand Down