Conversation
Zemnmez
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A user pointed out that the README pull request example interpolated
${{ github.event.pull_request.base.ref }}directly into a shell command. GitHub Actions expands${{ ... }}expressions before the shell runs, so copying that pattern into a workflow can let attacker-controlled values such as branch names break shell syntax and execute arbitrary commands.This change hardens both the published examples and the composite action itself so we are not shipping that pattern to users.
What changed
env:and consume it as quoted shell variablesdocs/security.mdexplaining why direct${{ ... }}interpolation insiderun:blocks is unsafeaction.ymlso action inputs and step outputs are passed into shell steps through environment variables instead of being spliced directly into commandsexamples/test-sandbox-protections.ymlto use the same safe patternVerification
run:blocksaction.ymlandexamples/test-sandbox-protections.ymlwithRubyYAML.load_fileto confirm the edited workflow files still parse