Add openai_base_url config override for built-in provider#12031
Merged
etraut-openai merged 7 commits intomainfrom Mar 14, 2026
Merged
Add openai_base_url config override for built-in provider#12031etraut-openai merged 7 commits intomainfrom
etraut-openai merged 7 commits intomainfrom
Conversation
bolinfest
reviewed
Feb 17, 2026
Collaborator
Author
|
@codex review |
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2598384a64
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
bolinfest
reviewed
Feb 20, 2026
etraut-openai
added a commit
that referenced
this pull request
Feb 24, 2026
etraut-openai
added a commit
that referenced
this pull request
Feb 24, 2026
0efea7d to
960dc2a
Compare
bolinfest
approved these changes
Mar 13, 2026
Collaborator
bolinfest
left a comment
There was a problem hiding this comment.
Nice job! All my comments are small stuff, so feel free to take it or leave it.
I think I'll ask Codex to create that Clippy rule, though...
etraut-openai
added a commit
that referenced
this pull request
Mar 14, 2026
3286d14 to
7c71d1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We regularly get bug reports from users who mistakenly have the
OPENAI_BASE_URLenvironment variable set. This PR deprecates this environment variable in favor of a top-level config keyopenai_base_urlthat is used for the same purpose. By making it a config key, it will be more visible to users. It will also participate in all of the infrastructure we've added for layered and managed configs.Summary
openai_base_urltop-level config key, update schema/tests, and route the built-in openai provider through it whileOPENAI_BASE_URLenv var but warn user of deprecation when noopenai_base_urlconfig key is present