Skip to content

Add openai_base_url config override for built-in provider#12031

Merged
etraut-openai merged 7 commits intomainfrom
etraut/openai_base_url
Mar 14, 2026
Merged

Add openai_base_url config override for built-in provider#12031
etraut-openai merged 7 commits intomainfrom
etraut/openai_base_url

Conversation

@etraut-openai
Copy link
Copy Markdown
Collaborator

@etraut-openai etraut-openai commented Feb 17, 2026

We regularly get bug reports from users who mistakenly have the OPENAI_BASE_URL environment variable set. This PR deprecates this environment variable in favor of a top-level config key openai_base_url that is used for the same purpose. By making it a config key, it will be more visible to users. It will also participate in all of the infrastructure we've added for layered and managed configs.

Summary

  • introduce the openai_base_url top-level config key, update schema/tests, and route the built-in openai provider through it while
  • fall back to deprecated OPENAI_BASE_URL env var but warn user of deprecation when no openai_base_url config key is present
  • update CLI, SDK, and TUI code to prefer the new config path (with a deprecated env-var fallback) and document the SDK behavior change
@etraut-openai
Copy link
Copy Markdown
Collaborator Author

@codex review

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2598384a64

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Collaborator

@bolinfest bolinfest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! All my comments are small stuff, so feel free to take it or leave it.

I think I'll ask Codex to create that Clippy rule, though...

@etraut-openai etraut-openai force-pushed the etraut/openai_base_url branch from 3286d14 to 7c71d1e Compare March 14, 2026 01:25
@etraut-openai etraut-openai merged commit 4b9d5c8 into main Mar 14, 2026
29 of 32 checks passed
@etraut-openai etraut-openai deleted the etraut/openai_base_url branch March 14, 2026 02:12
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants