fix: support managed network allowlist controls#12752
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5cb9778652
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
2adec7c to
83b5428
Compare
In general, To set defaults that users can amend, that is supposed to go in (Though similar to |
|
yep I have this for |
92c8c35 to
ba2d1b5
Compare
Summary
requirements.tomlallowed_domainsanddenied_domainsas managed network baselines for the proxyexperimental_network.managed_allowed_domains_only = trueto pin the effective allowlist to managed entries, ignore user allowlist additions, and hard-deny non-managed domains without promptingmanaged_allowed_domains_onlyanywhere managed network enforcement is active, including full access, while continuing to respect denied domains from all sourcesBehavior
Assuming
requirements.tomldefines bothexperimental_network.allowed_domainsandexperimental_network.denied_domains.Default mode
experimental_network.allowed_domainsplus user or persisted allowlist additions.experimental_network.denied_domainsplus user or persisted denylist additions.experimental_network.managed_allowed_domains_only = true, only managedallowed_domainsare respected, user allowlist additions are ignored, and non-managed domains are hard-denied without prompting.Full access
experimental_network.allowed_domains.experimental_network.denied_domains.experimental_network.managed_allowed_domains_only = truenow also applies in full access, so managed-only behavior remains in effect anywhere managed network enforcement is active.