chore(app-server): delete v1 RPC methods and notifications#13375
Merged
chore(app-server): delete v1 RPC methods and notifications#13375
Conversation
Collaborator
Author
|
@codex review |
6f66f01 to
350418c
Compare
Contributor
|
Codex Review: Didn't find any major issues. Swish! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
bolinfest
approved these changes
Mar 3, 2026
fc6932e to
532a61a
Compare
7d48d95 to
d2d630f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This removes the old app-server v1 methods and notifications we no longer need, while keeping the small set the main codex app client still depends on for now.
The remaining legacy surface is:
initializegetConversationSummarygetAuthStatusgitDiffToRemotefuzzyFileSearchfuzzyFileSearch/sessionStartfuzzyFileSearch/sessionUpdatefuzzyFileSearch/sessionStopAnd the raw
codex/event/*notifications emitted from core. These notifications will be removed in a followup PR.What changed
authStatusChange,loginChatGptComplete, andsessionConfiguredgetConversationSummaryTesting
just write-app-server-schemacargo test -p codex-app-server-protocolcargo test -p codex-app-server