Skip to content

chore(app-server): delete v1 RPC methods and notifications#13375

Merged
owenlin0 merged 2 commits intomainfrom
owen/remove_v1_methods
Mar 3, 2026
Merged

chore(app-server): delete v1 RPC methods and notifications#13375
owenlin0 merged 2 commits intomainfrom
owen/remove_v1_methods

Conversation

@owenlin0
Copy link
Copy Markdown
Collaborator

@owenlin0 owenlin0 commented Mar 3, 2026

Summary

This removes the old app-server v1 methods and notifications we no longer need, while keeping the small set the main codex app client still depends on for now.

The remaining legacy surface is:

  • initialize
  • getConversationSummary
  • getAuthStatus
  • gitDiffToRemote
  • fuzzyFileSearch
  • fuzzyFileSearch/sessionStart
  • fuzzyFileSearch/sessionUpdate
  • fuzzyFileSearch/sessionStop

And the raw codex/event/* notifications emitted from core. These notifications will be removed in a followup PR.

What changed

  • removed deprecated v1 request variants from the protocol and app-server dispatcher
  • removed deprecated typed notifications: authStatusChange, loginChatGptComplete, and sessionConfigured
  • updated the app-server test client to use v2 flows instead of deleted v1 flows
  • deleted legacy-only app-server test suites and added focused coverage for getConversationSummary
  • regenerated app-server schema fixtures and updated the MCP interface docs to match the remaining compatibility surface

Testing

  • just write-app-server-schema
  • cargo test -p codex-app-server-protocol
  • cargo test -p codex-app-server
@owenlin0 owenlin0 changed the title chore(app-server): delete v1 RPC methods Mar 3, 2026
@owenlin0 owenlin0 marked this pull request as ready for review March 3, 2026 17:56
@owenlin0
Copy link
Copy Markdown
Collaborator Author

owenlin0 commented Mar 3, 2026

@codex review

@owenlin0 owenlin0 force-pushed the owen/remove_v1_methods branch from 6f66f01 to 350418c Compare March 3, 2026 18:03
@owenlin0 owenlin0 requested review from bolinfest and celia-oai March 3, 2026 18:03
@chatgpt-codex-connector
Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. Swish!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@owenlin0 owenlin0 force-pushed the owen/remove_v1_methods branch from fc6932e to 532a61a Compare March 3, 2026 19:58
@owenlin0 owenlin0 force-pushed the owen/remove_v1_methods branch from 7d48d95 to d2d630f Compare March 3, 2026 20:51
@owenlin0 owenlin0 merged commit 167158f into main Mar 3, 2026
29 of 31 checks passed
@owenlin0 owenlin0 deleted the owen/remove_v1_methods branch March 3, 2026 21:18
@github-actions github-actions bot locked and limited conversation to collaborators Mar 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants