core/protocol: add structured macOS additional permissions and merge them into sandbox execution#13499
Merged
core/protocol: add structured macOS additional permissions and merge them into sandbox execution#13499
Conversation
celia-oai
force-pushed
the
dev/cc/merge-sandbox-3
branch
3 times, most recently
from
47f5b05 to
b09d16f
Compare
celia-oai
force-pushed
the
dev/cc/merge-sandbox-3
branch
3 times, most recently
from
4767637 to
ccec75e
Compare
celia-oai
force-pushed
the
dev/cc/merge-sandbox-3
branch
from
ccec75e to
a3a21c0
Compare
bolinfest
approved these changes
Mar 5, 2026
Collaborator
dylan-hurd-oai
left a comment
dylan-hurd-oai
left a comment
There was a problem hiding this comment.
Overall aligned with this direction! Left some comments on code structure
| policy.clone() | ||
| }; | ||
| #[cfg(not(target_os = "macos"))] | ||
| let macos_seatbelt_profile_extensions = None; |
Collaborator
There was a problem hiding this comment.
Likely out of scope of this PR, but it feels like a really leaky abstraction to have to use target_os macros everywhere we declare this variable, particularly when it's part of the effective_sandbox_permissions constructor. I wonder if we could make this easier to work with somehow, e.g. passing around the outer struct more consistently
celia-oai
force-pushed
the
dev/cc/merge-sandbox-2
branch
3 times, most recently
from
66f9918 to
9911c6a
Compare
celia-oai
force-pushed
the
dev/cc/merge-sandbox-3
branch
from
a3a21c0 to
906f7bd
Compare
celia-oai
force-pushed
the
dev/cc/merge-sandbox-3
branch
6 times, most recently
from
766c1d3 to
c166206
Compare
celia-oai
force-pushed
the
dev/cc/merge-sandbox-3
branch
from
c166206 to
c9db22c
Compare
celia-oai
force-pushed
the
dev/cc/merge-sandbox-3
branch
from
741e0e7 to
fc9ee3a
Compare
celia-oai
changed the title
dylan-hurd-oai
approved these changes
Mar 5, 2026
celia-oai
force-pushed
the
dev/cc/merge-sandbox-3
branch
from
0e5617a to
655aa8b
Compare
celia-oai
force-pushed
the
dev/cc/merge-sandbox-3
branch
from
655aa8b to
9b9ca98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
network,file_system, andmacosadditional permissions.