Harden js_repl emitImage to accept only data: URLs#13507
Merged
Conversation
Contributor
Author
|
@codex review |
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2e69ea53d0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. Swish! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
pakrym-oai
approved these changes
Mar 5, 2026
1148169 to
418ea45
Compare
418ea45 to
c22c1c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
normalizeEmitImageUrland enforce that string-valuedcodex.emitImage(...)inputs andinput_image/content-item paths only accept non-emptydata:URLs; byte-based paths still produce data URLs as before (kernel.js).validate_emitted_image_urland checkEmitImagerequests before creatingFunctionCallOutputContentItem::InputImage, returning an error to the kernel if the URL is not adata:URL (mod.rs).js_repl_emit_image_rejects_non_data_urlto assert rejection of non-data URLs and updated user-facing docs/instruction text to statedata URLsupport instead of generic direct image URLs (mod.rs,docs/js_repl.md,project_doc.rs).Testing
just fmtincodex-rs; it completed successfully.cargo test -p codex-core js_repl_emit_image_rejects_non_data_url) but executing the test in this environment failed due to a missing system dependency required bycodex-linux-sandbox(the vendoredbubblewrapbuild requireslibcap.pcviapkg-config), so the test could not be run here.cargo testinvocation with and without default features; both compile/test attempts were blocked by the same missing systemlibcapdependency in this environment.Codex Task