Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fbdf5bd563
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let include_artifact_tools = features.enabled(Feature::Artifact) | ||
| && codex_artifacts::is_js_runtime_available( | ||
| codex_home, | ||
| PINNED_ARTIFACT_RUNTIME_VERSION, | ||
| ); |
There was a problem hiding this comment.
Do not gate include_artifact_tools on is_js_runtime_available(...). This check requires a cached runtime or preinstalled machine JS runtime before exposing the tool. But the handler now uses ArtifactRuntimeManager::ensure_installed() to fetch the runtime on demand, so fresh environments can get stuck in a catch-22 where the tool is hidden and installation never happens.
Useful? React with 👍 / 👎.
1 participant
No description provided.