fix(core): skip exec approval for permissionless skill scripts#13791
Merged
fix(core): skip exec approval for permissionless skill scripts#13791
Conversation
leoshimo-oai
approved these changes
Mar 6, 2026
Comment on lines
+585
to
+587
| return Ok(EscalationDecision::escalate( | ||
| EscalationExecution::TurnDefault, | ||
| )); |
Contributor
There was a problem hiding this comment.
Does this need to switch based on approval_policy is RejectAskForApproval, or is that enforced at some other layer?
Contributor
There was a problem hiding this comment.
i.e. if RejectAskForApproval's sandboxApproval is false, I actually do expect an approval prompt in that case.
Collaborator
Author
There was a problem hiding this comment.
this will be a follow-up PR!
dylan-hurd-oai
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Permissionless skills should inherit the current turn sandbox directly. Prompting for exec approval in that case adds friction without granting any additional capability.