feat: make interrupt state not final for multi-agents#13850
Merged
Conversation
gabec-openai
approved these changes
Mar 7, 2026
Contributor
gabec-openai
left a comment
gabec-openai
left a comment
There was a problem hiding this comment.
locally patched - seems to work much better!
…inal # Conflicts: # codex-rs/app-server-protocol/schema/json/EventMsg.json # codex-rs/app-server-protocol/schema/json/codex_app_server_protocol.schemas.json # codex-rs/app-server-protocol/schema/json/codex_app_server_protocol.v2.schemas.json # codex-rs/app-server-protocol/schema/typescript/AgentStatus.ts # codex-rs/app-server-protocol/src/protocol/thread_history.rs # codex-rs/core/src/agent/control.rs # codex-rs/core/src/tools/handlers/multi_agents.rs
Collaborator
Author
|
@codex review |
Collaborator
|
@codex are we sure this short circuits the final notification injection? |
aibrahim-oai
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
interruptedan agent state and make it not final. As a result, awaitwon't return on an interrupted agent and no notification will be send to the parent agent.The rationals are: