Stabilize zsh fork app-server tests#13872
Merged
aibrahim-oai merged 3 commits intomainfrom Mar 9, 2026
Merged
Conversation
aibrahim-oai
added a commit
that referenced
this pull request
Mar 7, 2026
aibrahim-oai
added a commit
that referenced
this pull request
Mar 7, 2026
aibrahim-oai
added a commit
that referenced
this pull request
Mar 7, 2026
3d91099 to
c158d76
Compare
9cf75a7 to
bd60d6c
Compare
owenlin0
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
turn_start_shell_zsh_fork_executes_command_v2now keeps the shell command alive with a file marker until the interrupt arrives instead of using a command that can finish too quickly.turn_start_shell_zsh_fork_subcommand_decline_marks_parent_declined_v2now waits forturn/completedbefore sending a fallback interrupt and accepts the real terminal outcomes observed across platforms.Why this fixes the flake
Scope