Stabilize realtime startup context tests#13876
Merged
aibrahim-oai merged 5 commits intomainfrom Mar 9, 2026
Merged
Conversation
aibrahim-oai
added a commit
that referenced
this pull request
Mar 7, 2026
aibrahim-oai
added a commit
that referenced
this pull request
Mar 7, 2026
aibrahim-oai
added a commit
that referenced
this pull request
Mar 7, 2026
aibrahim-oai
added a commit
that referenced
this pull request
Mar 7, 2026
209eb95 to
c491a67
Compare
657aca7 to
fbfb087
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
connection 1 / request 0.session.instructions, regardless of which websocket connection won the accept-order race on the runner.Why this fixes the flake
session.updatedclient event and then inspected a fixed websocket slot.response.createinstead of the startup-context-bearingsession.updaterequest the test actually cares about.session.instructionsremoves both ordering assumptions and makes the assertion line up with the actual contract under test.Scope