Skip to content

Stabilize shell serialization tests#13877

Merged
aibrahim-oai merged 2 commits intomainfrom
dev/flaky-shell-serialization-tests
Mar 8, 2026
Merged

Stabilize shell serialization tests#13877
aibrahim-oai merged 2 commits intomainfrom
dev/flaky-shell-serialization-tests

Conversation

@aibrahim-oai
Copy link
Copy Markdown
Collaborator

@aibrahim-oai aibrahim-oai commented Mar 7, 2026

What changed

  • The duration-recording fixture sleep was reduced from a large artificial delay to 0.2s, and the assertion floor was lowered to 0.1s.
  • The shell tool fixtures now force login = false so they do not invoke login-shell startup paths.

Why this fixes the flake

  • The old tests were paying for two kinds of noise that had nothing to do with the feature being validated: oversized sleep time and variable shell initialization cost.
  • Login shells can pick up runner-specific startup files and incur inconsistent startup latency.
  • The test only needs to prove that we record a nontrivial duration and preserve shell output. A shorter fixture delay plus a non-login shell keeps that coverage while removing runner-dependent wall-clock variance.

Scope

  • Test-only change.
@aibrahim-oai aibrahim-oai force-pushed the dev/flaky-shell-serialization-tests branch from 5176268 to 79ea166 Compare March 8, 2026 04:08
@aibrahim-oai aibrahim-oai merged commit 1f150ed into main Mar 8, 2026
31 checks passed
@aibrahim-oai aibrahim-oai deleted the dev/flaky-shell-serialization-tests branch March 8, 2026 20:37
@github-actions github-actions bot locked and limited conversation to collaborators Mar 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants