Skip to content

Stabilize incomplete SSE retry test#13879

Merged
aibrahim-oai merged 1 commit intomainfrom
dev/flaky-stream-no-completed-retry
Mar 10, 2026
Merged

Stabilize incomplete SSE retry test#13879
aibrahim-oai merged 1 commit intomainfrom
dev/flaky-stream-no-completed-retry

Conversation

@aibrahim-oai
Copy link
Copy Markdown
Collaborator

@aibrahim-oai aibrahim-oai commented Mar 7, 2026

What changed

  • The retry test now uses the same streaming SSE test server used by production-style tests instead of a wiremock sequence.
  • The fixture is resolved via find_resource!, and the test asserts that exactly two outbound requests were sent.

Why this fixes the flake

  • The old wiremock sequence approximated early-close behavior, but it did not reproduce the same streaming semantics the real client sees.
  • That meant the retry path depended on mock implementation details instead of on the actual transport behavior we care about.
  • Switching to the streaming SSE helper makes the test exercise the real early-close/retry contract, and counting requests directly verifies that we retried exactly once rather than merely hoping the sequence aligned.

Scope

  • Test-only change.
@aibrahim-oai aibrahim-oai force-pushed the dev/flaky-stream-no-completed-retry branch from d9624da to f077e40 Compare March 8, 2026 04:32
@aibrahim-oai aibrahim-oai requested review from bolinfest and pakrym-oai and removed request for bolinfest March 8, 2026 06:31
@aibrahim-oai aibrahim-oai merged commit aa6a57d into main Mar 10, 2026
57 of 61 checks passed
@aibrahim-oai aibrahim-oai deleted the dev/flaky-stream-no-completed-retry branch March 10, 2026 05:34
@github-actions github-actions bot locked and limited conversation to collaborators Mar 10, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

1 participant