Skip to content

Stabilize RMCP pid file cleanup test#13881

Merged
aibrahim-oai merged 1 commit intomainfrom
dev/flaky-rmcp-pid-file-test
Mar 9, 2026
Merged

Stabilize RMCP pid file cleanup test#13881
aibrahim-oai merged 1 commit intomainfrom
dev/flaky-rmcp-pid-file-test

Conversation

@aibrahim-oai
Copy link
Copy Markdown
Collaborator

@aibrahim-oai aibrahim-oai commented Mar 7, 2026

What changed

  • The pid-file cleanup test now keeps polling when the pid file exists but is still empty.
  • Assertions only proceed once the wrapper has actually written the child pid.

Why this fixes the flake

  • File creation and pid writing are not atomic as one logical action from the test’s point of view.
  • The previous test sometimes won the race and read the file in the tiny window after creation but before the pid bytes were flushed.
  • Treating “empty file” as “not ready yet” synchronizes the test on the real event we need: the wrapper has finished publishing the child pid.

Scope

  • Test-only change.
@aibrahim-oai aibrahim-oai force-pushed the dev/flaky-rmcp-pid-file-test branch from eb4a956 to c919867 Compare March 8, 2026 05:01
@aibrahim-oai aibrahim-oai requested review from etraut-openai and jif-oai and removed request for jif-oai March 8, 2026 06:32
@aibrahim-oai aibrahim-oai merged commit 6052558 into main Mar 9, 2026
51 of 53 checks passed
@aibrahim-oai aibrahim-oai deleted the dev/flaky-rmcp-pid-file-test branch March 9, 2026 17:01
@github-actions github-actions bot locked and limited conversation to collaborators Mar 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants