Skip to content

Stabilize protocol schema fixture generation#13886

Merged
aibrahim-oai merged 4 commits intomainfrom
dev/flaky-protocol-schema-fixtures
Mar 9, 2026
Merged

Stabilize protocol schema fixture generation#13886
aibrahim-oai merged 4 commits intomainfrom
dev/flaky-protocol-schema-fixtures

Conversation

@aibrahim-oai
Copy link
Copy Markdown
Collaborator

@aibrahim-oai aibrahim-oai commented Mar 7, 2026

What changed

  • TypeScript schema fixture generation now goes through in-memory tree helpers rather than a heavier on-disk generation path.
  • The comparison logic normalizes generated banner and path differences that are not semantically relevant to the exported schema.
  • TypeScript and JSON fixture coverage are split into separate tests, and the expensive schema-export tests are serialized in nextest.

Why this fixes the flake

  • The original fixture coverage mixed several heavy codegen paths into one monolithic test and then compared generated output that included incidental banner/path differences.
  • On Windows CI, that combination created both runtime pressure and output variance unrelated to the schema shapes we actually care about.
  • Splitting the coverage isolates failures by format, in-memory generation reduces filesystem churn, normalization strips generator noise, and serializing the heavy tests removes parallel resource contention.

Scope

  • Production helper change plus test changes.
aibrahim-oai added a commit that referenced this pull request Mar 7, 2026
aibrahim-oai added a commit that referenced this pull request Mar 7, 2026
aibrahim-oai added a commit that referenced this pull request Mar 7, 2026
@aibrahim-oai aibrahim-oai force-pushed the dev/flaky-protocol-schema-fixtures branch from 1a0cfca to 1afffdb Compare March 7, 2026 19:13
aibrahim-oai added a commit that referenced this pull request Mar 7, 2026
aibrahim-oai added a commit that referenced this pull request Mar 8, 2026
@aibrahim-oai aibrahim-oai force-pushed the dev/flaky-protocol-schema-fixtures branch from 58b4942 to c96a948 Compare March 8, 2026 05:41
@aibrahim-oai aibrahim-oai force-pushed the dev/flaky-protocol-schema-fixtures branch from c96a948 to a4fe524 Compare March 8, 2026 05:47
@aibrahim-oai
Copy link
Copy Markdown
Collaborator Author

@codex review this

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a4fe5244d3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@aibrahim-oai
Copy link
Copy Markdown
Collaborator Author

@codex review this

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cd1bf5a2fe

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@aibrahim-oai
Copy link
Copy Markdown
Collaborator Author

@codex review this

@chatgpt-codex-connector
Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. Bravo.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@aibrahim-oai aibrahim-oai merged commit 831ee51 into main Mar 9, 2026
31 checks passed
@aibrahim-oai aibrahim-oai deleted the dev/flaky-protocol-schema-fixtures branch March 9, 2026 20:51
@github-actions github-actions bot locked and limited conversation to collaborators Mar 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants