Skip to content

fix(ci): restore guardian coverage and bazel unit tests#13912

Merged
charley-oai merged 19 commits intomainfrom
codex/viyatb/fix-guardian-test-failures
Mar 8, 2026
Merged

fix(ci): restore guardian coverage and bazel unit tests#13912
charley-oai merged 19 commits intomainfrom
codex/viyatb/fix-guardian-test-failures

Conversation

@charley-oai
Copy link
Copy Markdown
Contributor

@charley-oai charley-oai commented Mar 7, 2026

Summary

  • restore the guardian review request snapshot test and its tracked snapshot after it was dropped from main
  • make Bazel Rust unit-test wrappers resolve runfiles correctly on manifest-only platforms like macOS and point Insta at the real workspace root
  • harden the shell-escalation socket-closure assertion so the musl Bazel test no longer depends on fd reuse behavior

Verification

  • cargo test -p codex-core guardian_review_request_layout_matches_model_visible_request_snapshot
  • cargo test -p codex-shell-escalation
  • bazel test //codex-rs/exec:exec-unit-tests //codex-rs/shell-escalation:shell-escalation-unit-tests

Supersedes #13894.

Codex author

codex resume 019cc9d6-bd74-7971-acc1-24ce42e715d7

@charley-oai charley-oai force-pushed the codex/viyatb/fix-guardian-test-failures branch from d690d47 to 666efa1 Compare March 7, 2026 23:41
@charley-oai charley-oai force-pushed the codex/viyatb/fix-guardian-test-failures branch from 68c6423 to 39c3239 Compare March 8, 2026 00:29
@charley-oai
Copy link
Copy Markdown
Contributor Author

@codex review this

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9a2633df5e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@charley-oai
Copy link
Copy Markdown
Contributor Author

@codex review this

@chatgpt-codex-connector
Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

charley-oai added a commit that referenced this pull request Mar 8, 2026
Co-authored-by: Codex <noreply@openai.com>
@charley-oai charley-oai requested a review from aibrahim-oai March 8, 2026 06:58
charley-oai added a commit that referenced this pull request Mar 8, 2026
Co-authored-by: Codex <noreply@openai.com>
@charley-oai charley-oai force-pushed the codex/viyatb/fix-guardian-test-failures branch from 16c4e96 to 172e39c Compare March 8, 2026 06:59
charley-oai added a commit that referenced this pull request Mar 8, 2026
Co-authored-by: Codex <noreply@openai.com>
@charley-oai charley-oai force-pushed the codex/viyatb/fix-guardian-test-failures branch from 172e39c to f23d33d Compare March 8, 2026 07:00
aibrahim-oai and others added 16 commits March 7, 2026 23:04
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Handle both Bazel source path variants for file!() while keeping unit-test snapshots rooted at the current Bazel test cwd.

Co-authored-by: Codex <noreply@openai.com>
Root Bazel unit-test snapshots at the Rust workspace inside the runfiles tree so insta finds the checked-in core and tui snapshots.

Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
charley-oai and others added 3 commits March 7, 2026 23:04
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
@charley-oai charley-oai force-pushed the codex/viyatb/fix-guardian-test-failures branch from f23d33d to 447dd09 Compare March 8, 2026 07:05
@charley-oai charley-oai merged commit 7ba1fcc into main Mar 8, 2026
31 checks passed
@charley-oai charley-oai deleted the codex/viyatb/fix-guardian-test-failures branch March 8, 2026 19:05
@github-actions github-actions bot locked and limited conversation to collaborators Mar 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants