Skip to content

Stabilize app list update ordering test#14052

Merged
aibrahim-oai merged 1 commit intomainfrom
dev/app-list-update-ordering-test
Mar 9, 2026
Merged

Stabilize app list update ordering test#14052
aibrahim-oai merged 1 commit intomainfrom
dev/app-list-update-ordering-test

Conversation

@aibrahim-oai
Copy link
Copy Markdown
Collaborator

Summary

  • make list_apps_waits_for_accessible_data_before_emitting_directory_updates accept the two valid notification paths the server can emit
  • keep rejecting the real bug this test is meant to catch: a directory-only app/list/updated notification before accessible app data is available

Why this fixes the flake

The old test used a fixed 150ms silence window and assumed the first notification after that window had to be the fully merged final update. In CI, scheduling occasionally lets accessible app data arrive before directory data, so the first valid notification can be an accessible-only interim update. That made the test fail even though the server behavior was correct.

This change makes the test deterministic by reading notifications until the final merged payload arrives. Any interim update is only accepted if it contains accessible apps only; if the server ever emits inaccessible directory data before accessible data is ready, the test still fails immediately.

Change type

  • test-only; no production app-list logic changes
@aibrahim-oai aibrahim-oai merged commit 2bc3e52 into main Mar 9, 2026
29 of 31 checks passed
@aibrahim-oai aibrahim-oai deleted the dev/app-list-update-ordering-test branch March 9, 2026 07:16
@github-actions github-actions bot locked and limited conversation to collaborators Mar 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants