Skip to content

Stabilize resumed rollout messages#14060

Merged
aibrahim-oai merged 1 commit intomainfrom
dev/flaky-resume-rollout-stabilization
Mar 9, 2026
Merged

Stabilize resumed rollout messages#14060
aibrahim-oai merged 1 commit intomainfrom
dev/flaky-resume-rollout-stabilization

Conversation

@aibrahim-oai
Copy link
Copy Markdown
Collaborator

What changed

  • add a bounded resume_until_initial_messages helper in core/tests/suite/resume.rs
  • retry the resume call until initial_messages contains the fully persisted final turn shape before asserting

Why this fixes flakiness

The old test resumed once immediately after TurnComplete and sometimes read rollout state before the final turn had been persisted. That made the assertion race persistence timing instead of checking the resumed message shape. The new helper polls for up to two seconds in 10ms steps and only asserts once the expected message sequence is actually present, so the test waits for the real readiness condition instead of depending on a lucky timing window.

Scope

  • test-only
  • no production logic change
@haydenkwak
Copy link
Copy Markdown

To whoever is vibe-coding on codex-cli: please stop.

@aibrahim-oai aibrahim-oai merged commit fefd01b into main Mar 9, 2026
31 checks passed
@aibrahim-oai aibrahim-oai deleted the dev/flaky-resume-rollout-stabilization branch March 9, 2026 18:48
@github-actions github-actions bot locked and limited conversation to collaborators Mar 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants