feat(otel): Centralize OTEL metric names and shared tag builders#14117
Merged
feat(otel): Centralize OTEL metric names and shared tag builders#14117
Conversation
owenlin0
force-pushed
the
owen/refactor_metrics
branch
from
df85099 to
36597d6
Compare
Collaborator
Author
|
@codex review |
owenlin0
force-pushed
the
owen/refactor_metrics
branch
from
36597d6 to
2fff7e7
Compare
Contributor
|
Codex Review: Didn't find any major issues. Nice work! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
apanasenko-oai
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cleans up a bunch of metric plumbing that had started to drift.
The main change is making
codex-otelthe canonical home for shared metric definitions and metric tag helpers. I moved theturn/threadmetric names that were still duplicated into the OTEL metric registry, added a sharedmetrics::tagsmodule for common tag keys and session tag construction, and updatedSessionTelemetryto build its metadata tags through that shared path.On the codex-core side, TTFT/TTFM now use the shared metric-name constants instead of local string definitions. I also switched the obvious remaining turn/thread metric callsites over to the shared constants, and added a small helper so TTFT/TTFM can attach an optional sanitized client.name tag from TurnContext.
This should make follow-on telemetry work less ad hoc:
codex-coreandcodex-otel