Skip to content

app-server: add v2 filesystem APIs#14245

Merged
euroelessar merged 4 commits intomainfrom
ruslan/app-server-fs-api
Mar 13, 2026
Merged

app-server: add v2 filesystem APIs#14245
euroelessar merged 4 commits intomainfrom
ruslan/app-server-fs-api

Conversation

@euroelessar
Copy link
Copy Markdown
Collaborator

@euroelessar euroelessar commented Mar 10, 2026

Add a protocol-level filesystem surface to the v2 app-server so Codex clients can read and write files, inspect directories, and subscribe to path changes without relying on host-specific helpers.

High-level changes:

  • define the new v2 fs/readFile, fs/writeFile, fs/createDirectory, fs/getMetadata, fs/readDirectory, fs/remove, fs/copy RPCs
  • implement the app-server handlers, including absolute-path validation, base64 file payloads, recursive copy/remove semantics
  • document the API, regenerate protocol schemas/types, and add end-to-end tests for filesystem operations, copy edge cases

Testing plan:

  • validate protocol serialization and generated schema output for the new fs request, response, and notification types
  • run app-server integration coverage for file and directory CRUD paths, metadata/readDirectory responses, copy failure modes, and absolute-path validation
@euroelessar euroelessar requested a review from owenlin0 March 10, 2026 19:50
@euroelessar
Copy link
Copy Markdown
Collaborator Author

@codex review

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 27f1595287

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@euroelessar
Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown
Contributor

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

Failed to set up container
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Add the v2 app-server protocol and implementation for filesystem reads, writes, directory operations, metadata, copying, and removal. This also updates the schema fixtures, app-server documentation, and the v2 integration coverage for the filesystem API surface.
@euroelessar euroelessar force-pushed the ruslan/app-server-fs-api branch from f0e10b4 to 2f63af0 Compare March 13, 2026 00:02
@euroelessar euroelessar changed the title app-server: add v2 filesystem APIs and watch support Mar 13, 2026
…-fs-api

# Conflicts:
#	codex-rs/app-server/src/message_processor.rs
@euroelessar euroelessar merged commit f8f82bf into main Mar 13, 2026
32 checks passed
@euroelessar euroelessar deleted the ruslan/app-server-fs-api branch March 13, 2026 21:42
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants