Skip to content

fix: follow up on linux sandbox review nits#14440

Merged
bolinfest merged 2 commits intomainfrom
codex/viyatb/review-nits-followup
Mar 12, 2026
Merged

fix: follow up on linux sandbox review nits#14440
bolinfest merged 2 commits intomainfrom
codex/viyatb/review-nits-followup

Conversation

@viyatb-oai
Copy link
Copy Markdown
Collaborator

Summary

  • address the follow-up review nits from refactor: make bubblewrap the default Linux sandbox #13996 in a separate PR
  • make the approvals test command a raw string and keep the managed-network path using env proxy routing
  • inline --apply-seccomp-then-exec in the Linux sandbox inner command builder
  • remove the bubblewrap-specific sandbox metric tag path and drop the use_legacy_landlock shim from sandbox_tag/TurnMetadataState::new
  • restore the Feature import that origin/main currently still needs in connectors.rs

Testing

  • cargo test -p codex-linux-sandbox
  • focused codex-core tests were rerun/started, but the final verification pass was interrupted when I pushed at request
@viyatb-oai viyatb-oai requested a review from bolinfest March 12, 2026 06:45
@bolinfest bolinfest merged commit e99e8e4 into main Mar 12, 2026
31 checks passed
@bolinfest bolinfest deleted the codex/viyatb/review-nits-followup branch March 12, 2026 06:59
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants