Conversation
19580a6 to
f1b8627
Compare
pakrym-oai
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
PR #13783 moved the
codex.rsunit tests intocodex_tests.rs. This applies the same extraction pattern across the rest ofcodex-rs/coreso the production modules stay focused on runtime code instead of large inline test blocks.Keeping the tests in sibling files also makes follow-up edits easier to review because product changes no longer have to share a file with hundreds or thousands of lines of test scaffolding.
What changed
mod tests { ... }incodex-rs/core/src/**with a path-based module declaration*_tests.rsfile, usingmod_tests.rsformod.rsmodulescfg(...)guards and module-local structure so the refactor remains structural rather than behavioralTesting
cargo test -p codex-core --lib(1653 passed; 0 failed; 5 ignored)just fix -p codex-corecargo fmt --checkcargo shear