Skip to content

fix(cli): support legacy use_linux_sandbox_bwrap flag#14473

Merged
viyatb-oai merged 8 commits intomainfrom
codex/viyatb/legacy-linux-sandbox-flag-compat
Mar 12, 2026
Merged

fix(cli): support legacy use_linux_sandbox_bwrap flag#14473
viyatb-oai merged 8 commits intomainfrom
codex/viyatb/legacy-linux-sandbox-flag-compat

Conversation

@viyatb-oai
Copy link
Copy Markdown
Collaborator

@viyatb-oai viyatb-oai commented Mar 12, 2026

Summary

  • restore use_linux_sandbox_bwrap as a removed feature key so older --enable callers parse again
  • keep it as a no-op by leaving runtime behavior unchanged
  • add regression coverage for the legacy --enable path

Testing

  • Not run (updated and pushed quickly)
@viyatb-oai viyatb-oai requested a review from bolinfest March 12, 2026 15:06
Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8766948fa7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Collaborator

@bolinfest bolinfest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

…inux-sandbox-flag-compat

# Conflicts:
#	codex-rs/core/src/features.rs
@viyatb-oai viyatb-oai enabled auto-merge (squash) March 12, 2026 15:20
@viyatb-oai viyatb-oai disabled auto-merge March 12, 2026 16:33
@viyatb-oai viyatb-oai enabled auto-merge (squash) March 12, 2026 16:33
@viyatb-oai viyatb-oai merged commit a30b807 into main Mar 12, 2026
52 of 54 checks passed
@viyatb-oai viyatb-oai deleted the codex/viyatb/legacy-linux-sandbox-flag-compat branch March 12, 2026 16:34
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants