Skip to content

Fix MCP tool calling#14491

Merged
pakrym-oai merged 12 commits intomainfrom
pakrym/investigate-failing-mcp-calls
Mar 12, 2026
Merged

Fix MCP tool calling#14491
pakrym-oai merged 12 commits intomainfrom
pakrym/investigate-failing-mcp-calls

Conversation

@pakrym-oai
Copy link
Copy Markdown
Collaborator

@pakrym-oai pakrym-oai commented Mar 12, 2026

Properly escape mcp tool names and make tools only available via imports.

pakrym-oai added a commit that referenced this pull request Mar 12, 2026
@pakrym-oai pakrym-oai force-pushed the pakrym/investigate-failing-mcp-calls branch from cebac9f to 51470a3 Compare March 12, 2026 18:43
assert_eq!(
serde_json::from_str::<Vec<String>>(&output)?,
vec![
"AggregateError",
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check that we are not leaking extra stuff

@pakrym-oai pakrym-oai changed the title Explain MCP tool imports in code mode runner Mar 12, 2026
@pakrym-oai pakrym-oai merged commit dadffd2 into main Mar 12, 2026
28 of 32 checks passed
@pakrym-oai pakrym-oai deleted the pakrym/investigate-failing-mcp-calls branch March 12, 2026 20:38
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants