Persist js_repl codex helpers across cells#14503
Merged
Conversation
Contributor
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. Another round soon, please! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
705de5d to
ebba0c4
Compare
aaronl-openai
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This changes
js_replso saved references tocodex.tool(...)andcodex.emitImage(...)keep working across cells.Previously, those helpers were recreated per exec and captured that exec's
message.id. If a persisted object or saved closure reused an old helper in a later cell, the nested tool/image call could fail withjs_repl exec context not found.This patch:
codex.toolandcodex.emitImagehelper identities in the kernelAsyncLocalStorageWhy
We already support persistent top-level bindings across
js_replcells, so persisted objects should be able to reusecodexhelpers in later active cells. The bug was that helper identity was exec-scoped, not kernel-scoped.Using
AsyncLocalStoragefixes the cross-cell reuse case without falling back to a single global active exec that could accidentally attribute stale background callbacks to the wrong cell.