Start TUI on embedded app server by etraut-openai · Pull Request #14512 · openai/codex

etraut-openai · 2026-03-12T21:22:18Z

This PR is part of the effort to move the TUI on top of the app server. In a previous PR, we introduced an in-process app server and moved exec on top of it.

For the TUI, we want to do the migration in stages. The app server doesn't currently expose all of the functionality required by the TUI, so we're going to need to support a hybrid approach as we make the transition.

This PR changes the TUI initialization to instantiate an in-process app server and access its AuthManager and ThreadManager rather than constructing its own copies. It also adds a placeholder TUI event handler that will eventually translate app server events into TUI events. App server notifications are accepted but ignored for now. It also adds proper shutdown of the app server when the TUI terminates.

etraut-openai · 2026-03-12T21:22:36Z

@codex review

chatgpt-codex-connector

💡 Codex Review

codex/codex-rs/tui/src/app.rs

Lines 1755 to 1756 in db84242

    
           if let Some(exit_info) = exit_info { 
        
               return Ok(exit_info);

Shut down embedded app-server before early returns

App::run can return here when the model-migration prompt exits, but the only embedded_app_server.client.shutdown() call is later (line ~2070). That leaves the in-process client worker/runtime detached for this path. In long-lived hosts/tests this is a resource leak and can interfere with subsequent runs.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/app-server/src/message_processor.rs

etraut-openai · 2026-03-12T22:47:26Z

@codex review

chatgpt-codex-connector

💡 Codex Review

codex/codex-rs/tui/src/app.rs

Line 2019 in 73c1773

app.handle_event(tui, event).await?

Ensure embedded app-server always shuts down before returning

App::run starts an embedded server but this ? can return early from the loop on handler errors, bypassing the shutdown call at the end of the function. That leaves the in-process worker/task running until runtime teardown. Use a guard/finally-style path so embedded_app_server.client.shutdown() runs on both success and error exits.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/app-server/src/message_processor.rs

etraut-openai · 2026-03-12T23:55:19Z

@codex review

chatgpt-codex-connector

💡 Codex Review

codex/codex-rs/tui/src/app.rs

Lines 1996 to 2002 in c13e55b

    
           return Ok(AppExitInfo { 
        
               token_usage: app.token_usage(), 
        
               thread_id: app.chat_widget.thread_id(), 
        
               thread_name: app.chat_widget.thread_name(), 
        
               update_action: app.pending_update_action, 
        
               exit_reason, 
        
           });

Shut down embedded app server before early return

App::run returns from this update-notification exit path without calling embedded_app_server.client.shutdown(). InProcessAppServerClient has no Drop-based shutdown, so this leaves the in-process server worker/background tasks running until process exit. The shutdown call only exists in other exit paths, making this branch leak runtime resources.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

etraut-openai · 2026-03-13T00:20:30Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6bb10d2559

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/app.rs

etraut-openai · 2026-03-13T00:46:02Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f423a82226

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/app/app_server_adapter.rs

This reverts commit b1a837c.

…-startup # Conflicts: # codex-rs/app-server/src/message_processor.rs

pakrym-oai · 2026-03-13T16:08:38Z

codex-rs/core/src/auth.rs

        }
    }

+    pub fn clear_external_auth_refresher(&self) {


fcoury · 2026-03-13T17:21:17Z

It seems like I can't formally approve it but I reviewed and only had the nitpick above, so LGTM.

Start TUI on embedded app server

db84242

chatgpt-codex-connector bot reviewed Mar 12, 2026

View reviewed changes

codex-rs/app-server/src/message_processor.rs Show resolved Hide resolved

etraut-openai added 2 commits March 12, 2026 16:41

tui: address embedded app-server review feedback

ed2b307

app-server: restore MessageProcessor bootstrap invariant

73c1773

Merge branch 'main' into etraut/tui-app-server-startup

ada844a

chatgpt-codex-connector bot reviewed Mar 12, 2026

View reviewed changes

codex-rs/app-server/src/message_processor.rs Show resolved Hide resolved

codex: fix CI failure on PR #14512

c13e55b

chatgpt-codex-connector bot reviewed Mar 13, 2026

View reviewed changes

etraut-openai added 2 commits March 12, 2026 18:05

codex: quiet embedded app-server placeholder logs

2acadd8

codex: address PR review feedback (#14512)

6bb10d2

chatgpt-codex-connector bot reviewed Mar 13, 2026

View reviewed changes

codex-rs/tui/src/app.rs Outdated Show resolved Hide resolved

codex-rs/tui/src/app.rs Show resolved Hide resolved

etraut-openai added 2 commits March 12, 2026 18:33

codex: address PR review feedback (#14512)

bddbfa7

tui: extract app-server adapter module

f423a82

chatgpt-codex-connector bot reviewed Mar 13, 2026

View reviewed changes

codex-rs/tui/src/app/app_server_adapter.rs Outdated Show resolved Hide resolved

github-actions bot mentioned this pull request Mar 13, 2026

📊 AI CLI 工具社区动态日报 2026-03-13 gsscsd/big_model_radar#27

Open

etraut-openai added 6 commits March 12, 2026 19:02

codex: address PR review feedback (#14512)

b1a837c

Revert "codex: address PR review feedback (#14512)"

ac9b4f7

This reverts commit b1a837c.

tui: document app-server adapter module

0b5c966

codex: trim app-server adapter scope (#14512)

f23a500

tui: use neutral app-server adapter naming

17450c5

codex: simplify app-server adapter placeholders (#14512)

e86c560

github-actions bot mentioned this pull request Mar 13, 2026

📊 Bản tin hàng ngày công cụ AI CLI 2026-03-13 compasify/agents-radar#35

Open

etraut-openai added 2 commits March 12, 2026 20:12

tui: simplify app-server startup scaffolding

b6467e8

Merge remote-tracking branch 'origin/main' into etraut/tui-app-server…

bfa2c4c

…-startup # Conflicts: # codex-rs/app-server/src/message_processor.rs

etraut-openai marked this pull request as ready for review March 13, 2026 06:03

github-actions bot mentioned this pull request Mar 13, 2026

📊 AI CLI 工具社区动态日报 2026-03-13 rollysys/agents-radar#77

Open

pakrym-oai reviewed Mar 13, 2026

View reviewed changes

codex-rs/core/src/auth.rs

}

}

pub fn clear_external_auth_refresher(&self) {

Copy link
Copy Markdown

Collaborator

pakrym-oai Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooc, why?

pakrym-oai approved these changes Mar 13, 2026

View reviewed changes

etraut-openai merged commit 9dba733 into main Mar 13, 2026
32 checks passed

etraut-openai deleted the etraut/tui-app-server-startup branch March 13, 2026 18:04

github-actions bot locked and limited conversation to collaborators Mar 13, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Start TUI on embedded app server#14512

Start TUI on embedded app server#14512
etraut-openai merged 17 commits intomainfrom
etraut/tui-app-server-startup

etraut-openai commented Mar 12, 2026 •

edited

Loading

etraut-openai commented Mar 12, 2026

chatgpt-codex-connector bot left a comment

Uh oh!

etraut-openai commented Mar 12, 2026

chatgpt-codex-connector bot left a comment

Uh oh!

etraut-openai commented Mar 12, 2026

chatgpt-codex-connector bot left a comment

etraut-openai commented Mar 13, 2026

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

etraut-openai commented Mar 13, 2026

chatgpt-codex-connector bot left a comment

Uh oh!

pakrym-oai Mar 13, 2026

fcoury commented Mar 13, 2026

Uh oh!

Labels

3 participants

	return Ok(AppExitInfo {
	token_usage: app.token_usage(),
	thread_id: app.chat_widget.thread_id(),
	thread_name: app.chat_widget.thread_name(),
	update_action: app.pending_update_action,
	exit_reason,
	});

Conversation

etraut-openai commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

etraut-openai commented Mar 12, 2026

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

etraut-openai commented Mar 12, 2026

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

etraut-openai commented Mar 12, 2026

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

etraut-openai commented Mar 13, 2026

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

etraut-openai commented Mar 13, 2026

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

pakrym-oai Mar 13, 2026

Choose a reason for hiding this comment

fcoury commented Mar 13, 2026

Uh oh!

Labels

3 participants

etraut-openai commented Mar 12, 2026 •

edited

Loading