Rename reject approval policy to granular#14516
Merged
mousseau-oai merged 1 commit intomainfrom Mar 12, 2026
Merged
Conversation
mousseau-oai
force-pushed
the
dev/mousseau/reject-policy-rename
branch
from
9ca677d to
ae24bab
Compare
dylan-hurd-oai
approved these changes
Mar 12, 2026
Collaborator
dylan-hurd-oai
left a comment
dylan-hurd-oai
left a comment
There was a problem hiding this comment.
The scope of the rename looks great! My only concern is the breaking change to AskForApproval - users that have manually edited their config.toml to use this field will start seeing an error, and we never marked it as experimental.
I think usage/adoption would be low enough that we're okay with this, but in the future we should be clearer about marking this as experimental ahead of time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rejectapproval policy is now calledgranularwhere each property indicates if approval is allowed. RenamedFeature::RequestPermissionstoFeature::ExecPermissionApprovalsas the original name became confusing with therequest_permissionstool.