Skip to content

Add diagnostics for read_only_unless_trusted timeout flake#14518

Merged
aibrahim-oai merged 5 commits intomainfrom
dev/diag-approval-timeout-flake
Mar 13, 2026
Merged

Add diagnostics for read_only_unless_trusted timeout flake#14518
aibrahim-oai merged 5 commits intomainfrom
dev/diag-approval-timeout-flake

Conversation

@aibrahim-oai
Copy link
Copy Markdown
Collaborator

@aibrahim-oai aibrahim-oai commented Mar 12, 2026

Summary

  • add targeted diagnostic logging for the read_only_unless_trusted_requires_approval scenarios in approval_matrix_covers_all_modes
  • add a scoped timeout buffer only for ro_unless_trusted write-file scenarios: 1000ms -> 2000ms
  • keep all other write-file scenarios at 1000ms

Why

The last two main failures were both in codex-core::all suite::approvals::approval_matrix_covers_all_modes with exit_code=124 in the same scenario. This points to execution-time jitter in CI rather than a semantic approval-policy mismatch.

Notes

  • This does not introduce any >5s timeout and does not disable/quarantine tests.
  • The timeout increase is tightly scoped to the single flaky path and keeps the matrix deterministic under CI scheduling variance.
@aibrahim-oai aibrahim-oai merged commit c7e847a into main Mar 13, 2026
31 checks passed
@aibrahim-oai aibrahim-oai deleted the dev/diag-approval-timeout-flake branch March 13, 2026 06:51
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

1 participant