[bazel] Bump up cc and rust toolchains#14542
Merged
zbarsky-openai merged 2 commits intomainfrom Mar 13, 2026
Merged
Conversation
zbarsky-openai
commented
Mar 13, 2026
| inject_repo(crate, "zstd") | ||
|
|
||
| bazel_dep(name = "bzip2", version = "1.0.8.bcr.3") | ||
| bazel_dep(name = "libcap", version = "2.27.bcr.1") |
Contributor
Author
There was a problem hiding this comment.
moves this to not be interspersed with the modules used in the crates
bolinfest
approved these changes
Mar 13, 2026
| common:remote --jobs=800 | ||
| # TODO(team): Evaluate if this actually helps, zbarsky is not sure, everything seems bottlenecked on `core` either way. | ||
| # Enable pipelined compilation since we are not bound by local CPU count. | ||
| #common:remote --@rules_rust//rust/settings:pipelined_compilation |
Collaborator
There was a problem hiding this comment.
OK, so we're leaving this commented out for now?
Contributor
Author
There was a problem hiding this comment.
yeah, I wasn't sure if this was better or not, so I left a breadcrumb to make it easy to evaluate as a followup
zbarsky-openai
force-pushed
the
zbarsky/bumps
branch
from
015fdba to
a489f3d
Compare
zbarsky-openai
force-pushed
the
zbarsky/bumps
branch
from
a489f3d to
49a31e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lets us drop various patches and go all the way to a very clean setup.
In case folks are curious what was going on... we were depending on the toolchain finding stdlib headers as sibling files of
clang++, and for linking we were providing a-resource-dircontaining the runtime libs. However, some users of the cc toolchain (such as rust build scripts) do the equivalent of$CC $CCFLAGS $LDFLAGSso the-resource-dirwas being passed when compiling, which suppressed the default stdlib header location logic. The upstream fix was to swap to using-isystemto pass the stdlib headers, while carefully controlling the ordering to simulate them coming from the resource-dir.