Skip to content

Fix stale create_wait_tool reference#14639

Merged
charley-oai merged 1 commit intomainfrom
fix/create-exec-wait-tool-spec-test
Mar 13, 2026
Merged

Fix stale create_wait_tool reference#14639
charley-oai merged 1 commit intomainfrom
fix/create-exec-wait-tool-spec-test

Conversation

@charley-oai
Copy link
Copy Markdown
Contributor

@charley-oai charley-oai commented Mar 13, 2026

Summary

  • replace the stale create_wait_tool() reference in spec_tests.rs
  • use create_wait_agent_tool() to match the actual multi-agent tool rename from #14631
  • fix the resulting codex-core spec-test compile failure on current main

Context

#14631 renamed the model-facing multi-agent tool from wait to wait_agent and renamed the corresponding spec helper to create_wait_agent_tool().

One spec_tests.rs call site was left behind, so current main fails to compile codex-core tests with:

  • cannot find function create_wait_tool

Using create_wait_agent_tool() is the correct fix here; create_exec_wait_tool() would point at the separate exec wait tool and would not match the renamed multi-agent toolset.

Testing

  • not rerun locally after the rebase
@charley-oai charley-oai force-pushed the fix/create-exec-wait-tool-spec-test branch from 9cb41cd to 54bed8f Compare March 13, 2026 22:30
Co-authored-by: Codex <noreply@openai.com>
@charley-oai charley-oai force-pushed the fix/create-exec-wait-tool-spec-test branch from 54bed8f to 276fdb4 Compare March 13, 2026 22:32
@charley-oai charley-oai changed the title Fix stale exec wait spec helper Mar 13, 2026
@charley-oai charley-oai merged commit 467e621 into main Mar 13, 2026
29 of 31 checks passed
@charley-oai charley-oai deleted the fix/create-exec-wait-tool-spec-test branch March 13, 2026 22:35
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants