Skip to content

fix: tui freeze when sub-agents are present#14816

Merged
jif-oai merged 2 commits intomainfrom
jif/tui-close-freeze
Mar 16, 2026
Merged

fix: tui freeze when sub-agents are present#14816
jif-oai merged 2 commits intomainfrom
jif/tui-close-freeze

Conversation

@jif-oai
Copy link
Copy Markdown
Collaborator

@jif-oai jif-oai commented Mar 16, 2026

The issue was due to a circular Drop schema where the embedded app-server wait for some listeners that wait for this app-server them-selves.

The fix is an explicit cleaning

Repro:

  • Start codex
  • Ask it to spawn a sub-agent
  • Close Codex
  • It takes 5s to exit
@jif-oai
Copy link
Copy Markdown
Collaborator Author

jif-oai commented Mar 16, 2026

@codex review

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cdb967c5ed

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Collaborator

@etraut-openai etraut-openai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding and fixing this!

@jif-oai
Copy link
Copy Markdown
Collaborator Author

jif-oai commented Mar 16, 2026

@codex review

@jif-oai jif-oai merged commit c04a0a7 into main Mar 16, 2026
31 checks passed
@jif-oai jif-oai deleted the jif/tui-close-freeze branch March 16, 2026 16:42
@github-actions github-actions bot locked and limited conversation to collaborators Mar 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants